Add license auditing tooling to the repository. - #14442
Merged
Merged
Conversation
EtiennePerot
requested review from
aaltinaydev,
carzh,
fvoznika,
gvisor-bot,
konstantin-s-bogom,
manninglucas,
milantracy,
nixprime,
nybidari,
parth-opensrc,
relkochta,
rexren-gif,
shailend-g,
trantoji,
xinzhong and
zkoopmans
as code owners
August 27, 2026 01:01
EtiennePerot
removed request for
aaltinaydev,
carzh,
fvoznika,
gvisor-bot,
manninglucas,
nixprime,
nybidari,
parth-opensrc,
relkochta,
rexren-gif,
shailend-g,
trantoji,
xinzhong and
zkoopmans
August 27, 2026 01:02
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
milantracy
requested changes
Sep 4, 2026
| // CheckPolicy returns a problem for every dependency whose licenses are | ||
| // neither all in policy.AllowedLicenses nor covered by an exception, and for | ||
| // every malformed, stale, or unnecessary exception. | ||
| func CheckPolicy(entries []Entry, policy *Policy) []string { |
Collaborator
There was a problem hiding this comment.
the CheckPolicy here needs to be called inside or along with Verify to verify govenance/licensing.yaml.
The only place that CheckPolicy is called is licensecheck_test.go
This adds a tool to pull in and analyze the licenses of all dependencies in the project, and ensures they are in a set of allowed licenses. This ensures that if we add new deps down the line, they must be part of the set of allowed licenses.
EtiennePerot
force-pushed
the
licensecheck
branch
from
September 4, 2026 23:15
3020bab to
a59d18e
Compare
milantracy
approved these changes
Sep 4, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Sep 5, 2026
This adds a tool to pull in and analyze the licenses of all dependencies in the project, and ensures they are in a set of allowed licenses. This ensures that if we add new deps down the line, they must be part of the set of allowed licenses. Fix #14566 FUTURE_COPYBARA_INTEGRATE_REVIEW=#14442 from EtiennePerot:licensecheck a59d18e PiperOrigin-RevId: 976560219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a tool to pull in and analyze the licenses of all dependencies in the project, and ensures they are in a set of allowed licenses.
This ensures that if we add new deps down the line, they must be part of the set of allowed licenses.
Fix #14566