Skip to content

Hotplug#32

Open
nkovacs wants to merge 3 commits into
google:masterfrom
nkovacs:hotplug
Open

Hotplug#32
nkovacs wants to merge 3 commits into
google:masterfrom
nkovacs:hotplug

Conversation

@nkovacs

@nkovacs nkovacs commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

See #8

I'm going to squash this when done, but I didn't want to lose the history for now.

nkovacs added 2 commits March 7, 2018 18:37
Remove filtering, it's better to do it in the callback with
simple ifs.
Enumerate in go code to properly support cancellation and
distinguish enumerated devices.
Add support for deregistering from callback.
Fix memory leak.
@nkovacs

nkovacs commented Mar 18, 2018

Copy link
Copy Markdown
Contributor Author

The documentation is lying. LIBUSB_HOTPLUG_NO_FLAGS doesn't exist in libusb 1.0.17 (LIBUSB_HOTPLUG_ENUMERATE does). They added it later.

LIBUSB_HOTPLUG_NO_FLAGS was added later, it does not exist
in libusb 1.0.16. Its value is zero, so just use the zero value.
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.9%) to 73.319% when pulling 26ac067 on nkovacs:hotplug into d036636 on google:master.

1 similar comment
@coveralls

coveralls commented Mar 18, 2018

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.9%) to 73.319% when pulling 26ac067 on nkovacs:hotplug into d036636 on google:master.

@zagrodzki zagrodzki mentioned this pull request Sep 4, 2018
Elemecca added a commit to Elemecca/gousb that referenced this pull request Oct 19, 2018
@LitoMore

Copy link
Copy Markdown

Any updates?

Elemecca added a commit to Elemecca/gousb that referenced this pull request Oct 19, 2021
Elemecca added a commit to Elemecca/gousb that referenced this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants