Replace macos and windows client implementations with a generic one#87
Open
sorindumitru wants to merge 1 commit into
Open
Replace macos and windows client implementations with a generic one#87sorindumitru wants to merge 1 commit into
sorindumitru wants to merge 1 commit into
Conversation
It looks like the client here is only supported on Linux. There's two implementations for 2 OSs, I assume to prevent build failures when using the library from those systems. I'd like to be able to do the same for FreeBSD. Instead of adding a client_freebsd.go, it might be best to just have an implementation for non-linux OSs Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the client here is only supported on Linux. There's two implementations for 2 OSs, I assume to prevent build failures when using the library from those systems. I'd like to be able to do the same for FreeBSD. Instead of adding a client_freebsd.go, it might be best to just have an implementation for non-linux OSs.
This seems to build ok (I don't actually have a FreeBSD system available):