Various bug fixes#106
Open
ballesterosa wants to merge 8 commits into
Open
Conversation
…anic, and add test to verify panic doesn't occur
…tion cannot be bypassed by empty AnyMrTd slice
since a tdxHdr with Status == 0 can still have an invalid Quote size, it can cause an out of bounds panic when slicing tdxHdr.Data
Collaborator
|
Can you update the description to be more clear about the bugs being fixed? Also minor nit: I don't think the AI scanning needs to be mentioned in the title - the source of finding these bugs is less important than the actual changes being made. If the fixes aren't easily summarized then something like "Various bug fixes" should be fine. |
ballesterosa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Also adds
CGO_ENABLED: 0to the env in the CI.yml file to pass tests on the macOS runner and brings back reflect instead of cmp since cmp isn't recommended in a non-testing context.