Repository navigation
Fix Vulkan memoryType selection for QNX Screen buffer imports - #208
Merged
Merged
Conversation
... and fall-back to attempting selection using only Screen buffer memoryTypeBits when there is no combined type available.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the external memory allocation logic in vk_common_operations.cpp to fall back to the screen buffer's memory type bits when no common memory type is found with the VkImage, rather than returning an error. Review feedback highlights that this fallback violates Vulkan specification VUID-vkBindImageMemory-memory-01047, which can lead to failures or undefined behavior on strict Vulkan drivers. Additionally, a minor grammatical typo in the warning message was noted.
gurchetansingh
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and fall-back to attempting selection using only Screen buffer memoryTypeBits when there is no combined type available.