Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the allocExternalMemory function in vk_common_operations.cpp to refine the logic for VkExportMemoryAllocateInfo, ensuring that non-ColorBuffer allocations still receive the necessary export information when using Android AHB. Additionally, it adds a validation check to ensure info->handleInfo is only assigned if the Android hardware buffer export is successful. I have no feedback to provide.
ikicha
force-pushed
the
fix-ahb-vkbuffer-export
branch
2 times, most recently
from
October 14, 2026 15:42
4e85f50 to
b1d2813
Compare
…AHB mode When running in AndroidAHB mode, setupVkBuffer allocates host visible buffers without colorBufferInfo. Omission of VkExportMemoryAllocateInfo causes driver allocation failure or crash on hosts that require exportable memory for external buffers. Include VkExportMemoryAllocateInfo whenever AHB import is not used in AndroidAHB mode. Test: Run vkcube on Android guest VM
ikicha
force-pushed
the
fix-ahb-vkbuffer-export
branch
from
October 14, 2026 16:13
b1d2813 to
9de5947
Compare
Contributor
Author
|
@gurchetansingh @jmacnak can you review this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in AndroidAHB mode, setupVkBuffer allocates host visible buffers without colorBufferInfo. Omission of VkExportMemoryAllocateInfo causes driver allocation failure or crash on hosts that require exportable memory for external buffers. Include
VkExportMemoryAllocateInfo for non-colorbuffer allocations in AndroidAHB mode, and check handle validity before assigning info->handleInfo.
Test: Run vkcube on Android guest VM