Fix race conditions in polling client communicator Flush and Reset - #631
Merged
Conversation
copybara-service
Bot
force-pushed
the
cl/949430003
branch
2 times, most recently
from
August 18, 2026 15:38
7816847 to
0dd7f20
Compare
Fixes concurrency and synchronization issues in the polling client communicator around Flush() and Reset() while preserving the original scheduling, throttling, and lifecycle
behaviors:
1. Replaces the single-consumer `pollComplete` channel with a broadcast channel closure mechanism (`pollDone chan struct{}`), ensuring multiple concurrent `Flush()` callers all wake up properly without channel read contention.
2. Replaces `pollDone` on `Reset()` and outbox enqueue to ensure `Flush()` waits for the appropriate poll cycle.
3. Differentiates `Reset()`-induced request cancellations from network failures (`wasReset`), preserving queued messages for immediate re-poll rather than NACKing them.
4. Preserves `lastActive` dynamic latency reduction, `oldestUnsent` buffer delay tracking, `FailureSuicideTimeSeconds` suicide timeout, and shutdown flush behavior.
PiperOrigin-RevId: 966620893
copybara-service
Bot
force-pushed
the
cl/949430003
branch
from
August 18, 2026 15:54
0dd7f20 to
7abe4d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race conditions in polling client communicator Flush and Reset
Fixes concurrency and synchronization issues in the polling client communicator around Flush() and Reset() while preserving the original scheduling, throttling, and lifecycle
behaviors:
pollCompletechannel with a broadcast channel closure mechanism (pollDone chan struct{}), ensuring multiple concurrentFlush()callers all wake up properly without channel read contention.pollDoneonReset()and outbox enqueue to ensureFlush()waits for the appropriate poll cycle.Reset()-induced request cancellations from network failures (wasReset), preserving queued messages for immediate re-poll rather than NACKing them.lastActivedynamic latency reduction,oldestUnsentbuffer delay tracking,FailureSuicideTimeSecondssuicide timeout, and shutdown flush behavior.