Fix asymmetric path escaping for file server request URLs - #578
Merged
Conversation
copybara-service
Bot
force-pushed
the
cl/811357156
branch
from
September 25, 2025 15:54
a09e924 to
11e8e09
Compare
The path components are already escaped twice on the client side before making the request. Once explicitly using `url.PathEscape()` on each component, and then by using `url.String()` which escapes the entire path again. On the server side, using `url.EscapedPath()` instead of `url.Path` caused the latter escaping step on the client side not to be unescaped. If a file in the filestore contains a special character (e.g. `/`), it could not be accessed due to this bug. PiperOrigin-RevId: 811375109
copybara-service
Bot
force-pushed
the
cl/811357156
branch
from
September 25, 2025 16:12
11e8e09 to
126fd45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix asymmetric path escaping for file server request URLs
The path components are already escaped twice on the client side before making the request. Once explicitly using
url.PathEscape()on each component, and then by usingurl.String()which escapes the entire path again.On the server side, using
url.EscapedPath()instead ofurl.Pathcaused the latter escaping step on the client side not to be unescaped.If a file in the filestore contains a special character (e.g.
/), it could not be accessed due to this bug.