bounds-check field id before indexing in reflection helpers#9157
Open
Usamak06 wants to merge 1 commit into
Open
bounds-check field id before indexing in reflection helpers#9157Usamak06 wants to merge 1 commit into
Usamak06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForAllFields() in reflection.cpp and FieldIdToIndex() used by the bfbs generators size a field-id-to-index vector to the field count and then store field_to_id_map[field->id()] = i. A reflection schema whose field id is greater than or equal to the field count passes structural verification but writes past the end of that heap vector, so loading an untrusted .bfbs (e.g. flatc generating Lua/Nim, or any caller of the public ForAllFields) gives a heap out-of-bounds write. Guarding the store with a bounds check on the id keeps both helpers in line with the same id() check already added to StructDef::Deserialize in #8988.