Reject mismatched point counts in legacy KD-tree streams - #1215
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Reject mismatched point counts in legacy KD-tree streams#1215carrerasdarren-cell wants to merge 1 commit into
carrerasdarren-cell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
The reproducer declares 168 points in the outer legacy attribute stream but 3,892,261,426 points in the nested KD-tree stream. The legacy path called the unbounded decoder overload, while its output iterator silently ignores writes beyond the allocated 168 entries. The decoder therefore continued processing the attacker-controlled nested count.
On an ASan build from
4723893, the input was accepted after 10.04 seconds. With this change, it is rejected before entropy decoding in 0.04 seconds.Testing
PointCloudKdTreeEncodingTest.*: 10/10 tests pass under ASanclang-format --dry-run --Werrorgit diff --checkFixes #1207