fix: ensure isFailed matches actual error count in Summary#395
Open
assassinaj602 wants to merge 2 commits into
Open
fix: ensure isFailed matches actual error count in Summary#395assassinaj602 wants to merge 2 commits into
assassinaj602 wants to merge 2 commits into
Conversation
The Summary class was counting errors with commentSpan differently from the isFailed check, causing 'FAILED: 0 issues found' when errors existed but without commentSpan. Now both isFailed and errors count use the same consistent logic. Fixes google#275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where dartdoc_test prints "FAILED: 0 issues found" when there are errors but none have commentSpan.
The Problem
The Summary class used different logic for
isFailedanderrorscount:isFailedcounted ALL errorserrorscounted only errors with commentSpanThis caused mismatched output when errors existed without commentSpan.
What I Changed
Summary.from()inlib/src/logger.dartto count all errors consistentlyisFailednow matcheserrors.length > 0Testing
Closes #275