Initial attempt at checks_ext#375
Draft
jonasfj wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bit of AI experimentation going on here.
I think more extensions for
check()is a good thing, maybe some of the good ideas from here can one day land inpackage:checks-- this package is an attempt to be more opinionated in the direction thatcheck(something)should be useful, for most cases ofsomething.Some open questions:
check(myCompleter).isCompleted()vscheck(myCompleter.isCompleted).isTrue(), where is the line for what extensions should offer and what should be preprocessed?check('a\nb\n\c').lines.contains('a')sayhas lines that:, but maybe the messages could bewhere lines ...or something else, because.linesis not really a property ofString, but useful a derived value.CC @natebosch WDYT?