tls: decode Uint24 from the field offset - #1822
Open
robstradling wants to merge 1 commit into
Open
Conversation
parseField decoded a Uint24 from the start of the supplied buffer rather than from the current offset, so any Uint24 that was not the first field in a structure was unmarshalled incorrectly.
robstradling
requested review from
mhutchinson
and removed request for
a team
September 2, 2026 17:09
Contributor
|
/gcbrun |
roger2hk
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`parseField` decoded a `Uint24` from the start of the supplied buffer rather than from the current offset, so any `Uint24` that was not the first field in a structure was unmarshalled incorrectly.
Same bug as fixed in transparency-dev/tesseract#932 (spotted there by @roger2hk as also existing here).