ct_server: gate plaintext Trillian gRPC behind explicit opt-in - #1760
Open
1seal wants to merge 1 commit into
Open
ct_server: gate plaintext Trillian gRPC behind explicit opt-in#17601seal wants to merge 1 commit into
1seal wants to merge 1 commit into
Conversation
- add --trillian_insecure_backend to explicitly allow plaintext - keep plaintext default only for local backends (loopback/unix) - refuse non-local plaintext without TLS - add unit tests for the policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1759
what changed:
--trillian_insecure_backend(default: false)--trillian_tls_ca_cert_fileis set--trillian_insecure_backendis set (unsafe override), orrationale:
this avoids a silent insecure-by-default transport configuration when ctfe ↔ trillian traffic crosses a network trust boundary, while keeping common single-host and dev deployments working.
operator impact / migration:
--trillian_tls_ca_cert_file, ct_server will now refuse to start unless you explicitly set--trillian_insecure_backend.--trillian_tls_ca_cert_file.testing:
go test ./trillian/ctfe/ct_server