Fix Base64 histogram overflow#1510
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1509.
When Base64 mode adds a dedicated literal block type, both metablock paths can exceed the 256 histogram IDs representable by the context-map encoder:
Reserve the Base64 histogram slot while clustering, and only force the greedy Base64 split when all of its context histograms still fit. The regression test exercises the public streaming API at quality 9 and verifies a full encode/decode round trip.
Before this change, that test aborts with exit 134 and UBSan reports
index 256 out of bounds for uint8_t[256]inMoveToFrontTransform. With the fix, it passes at qualities 5, 9, and 11 under UBSan.Validation:
-std=c89 -pedantic -Wall -Wextra -WerrorThanks to @ylwango613 for the original report and reproducer.