Repository navigation
Conversation
LebedevRI
left a comment
There was a problem hiding this comment.
Counterpoint: can we just drop this whole file and replace it with "please use CMake build system. If you are not, it is up to you do deduce the right incantation"?
I used CMake build system, but I wanted to link my files with pre-built static benchmark library and engaged with problems. I would want to find out what's the problem from library docs. |
|
doesn't this mean that our cmake setup doesn't work correctly for Visual Studio? we just went through this for another PR and determined that the documentation update really doesn't say anything other than "use Visual Studio correctly". like this is almost identical to the first version of that PR. |
By "using cmake" i mean using cmake end-to-end. If one builds the library with cmake, |
|
Note that there's also autogenerated pkg-config |
|
Actually, I'm just a new user of your library and when I started to use it I collided with problems. I could solve it by thread on stackoverflow and think, maybe it would be useful to add this info in docs of library to simplify life of other users that decided (for any reason) to go the same way as I. I certainly don't know this project better than you and if you think that this PR doesn't make sense, let's drop it and related issue. I've already solved my issue and don't see the point in argumenting with you. |
|
@skryabae thank you! (Honestly, step one of having good development expirience is not to use visual studio, with second step being to not use windows altogether.) @dmah42 i propose to either A) drop that whole file, or B) replace it with "please use CMake build system. If you are not, it is up to you do deduce the right incantation. There's pkg-config .pc file for your convience". |
Closes #2309