Skip to content

Made a bit clearer platform_specific_build_instructions.md - #2328

Open
skryabae wants to merge 1 commit into
google:mainfrom
skryabae:chore/docs
Open

skryabae wants to merge 1 commit into
google:mainfrom
skryabae:chore/docs

Conversation

@skryabae

@skryabae skryabae commented Oct 8, 2026

Copy link
Copy Markdown

Closes #2309

@LebedevRI LebedevRI left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counterpoint: can we just drop this whole file and replace it with "please use CMake build system. If you are not, it is up to you do deduce the right incantation"?

@skryabae

skryabae commented Oct 9, 2026 •

Copy link
Copy Markdown
Author

Counterpoint: can we just drop this whole file and replace it with "please use CMake build system. If you are not, it is up to you do deduce the right incantation"?

I used CMake build system, but I wanted to link my files with pre-built static benchmark library and engaged with problems. I would want to find out what's the problem from library docs.

@dmah42

dmah42 commented Oct 9, 2026

Copy link
Copy Markdown
Member

doesn't this mean that our cmake setup doesn't work correctly for Visual Studio? we just went through this for another PR and determined that the documentation update really doesn't say anything other than "use Visual Studio correctly".

like this is almost identical to the first version of that PR.

@LebedevRI

LebedevRI commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Counterpoint: can we just drop this whole file and replace it with "please use CMake build system. If you are not, it is up to you do deduce the right incantation"?

I used CMake build system, but I wanted to link my files with pre-built static benchmark library and engaged with problems. I would want to find out what's the problem from library docs.

By "using cmake" i mean using cmake end-to-end. If one builds the library with cmake,
but then manually messes with the resulting built library, that's not "using cmake".

@LebedevRI

Copy link
Copy Markdown
Collaborator

Note that there's also autogenerated pkg-config .pc file that contains the incantation.
I'm really not very enthusiastic about also storing the needed link flags in docs.

@skryabae

skryabae commented Oct 9, 2026 •

Copy link
Copy Markdown
Author

Actually, I'm just a new user of your library and when I started to use it I collided with problems. I could solve it by thread on stackoverflow and think, maybe it would be useful to add this info in docs of library to simplify life of other users that decided (for any reason) to go the same way as I. I certainly don't know this project better than you and if you think that this PR doesn't make sense, let's drop it and related issue. I've already solved my issue and don't see the point in argumenting with you.

@LebedevRI

Copy link
Copy Markdown
Collaborator

@skryabae thank you!

(Honestly, step one of having good development expirience is not to use visual studio, with second step being to not use windows altogether.)

@dmah42 i propose to either A) drop that whole file, or B) replace it with "please use CMake build system. If you are not, it is up to you do deduce the right incantation. There's pkg-config .pc file for your convience".
Thoughts? Alternative suggestions?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Confusing title in docs/platform_specific_build_instructions.md

3 participants