Repository navigation
Apply UseManualTime to BM_bytes_per_second and BM_items_per_second - #2320
Merged
Merged
Conversation
Member
|
smart change. i wonder if we should also now check the output is calculating the rates correctly (we know the time is fixed so it should be assertable). |
stanbot8
force-pushed
the
fix/usemanualtime-bm-per-second
branch
3 times, most recently
from
October 6, 2026 14:35
591333c to
3a279ad
Compare
dmah42
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BM_bytes_per_secondandBM_items_per_secondintest/reporter_output_test.cccan record zero CPU time, producing infinite rates that failreporter_output_test's finite-number output checks.Use positive manual timing for both and update the report names to include
/manual_time.Whitespace-hidden diff
AI Disclosure: Reviewed by Codex.