Handle default harness correctly when resume a conversation. - #308
Merged
Conversation
zbl94
approved these changes
Jul 15, 2026
This was referenced Jul 16, 2026
joycel-github
added a commit
that referenced
this pull request
Jul 16, 2026
The controller does not read ExecRequest.LastSeq (no server-side reader in internal/controller); the client sends it but the server ignores it, so the documented "server replays later events to catch the client up" behavior does not happen. This regressed when the resume path was rewritten in #308 (previously handled in #262). - Quick Start: reconnect with --resume + the conversation ID instead of the non-functional --last-seq catch-up example. - Usage: describe --last-seq as reserved and note the server does not currently act on it; use --resume after a disconnect.
joycel-github
added a commit
that referenced
this pull request
Jul 16, 2026
Two related inaccuracies in the resume/disconnect docs: - --last-seq: the client sends ExecRequest.LastSeq but the controller has no server-side reader for it (regressed in the #308 controller rewrite; previously handled in #262), so the documented "server replays later events to catch the client up" behavior does not happen. Tracked in #320. - --resume: it only re-runs an execution that is still pending; if the previous execution already completed it returns without doing anything. The earlier wording implied a general disconnect/replay recovery. Reword Quick Start and the --resume/--last-seq option docs to match the actual controller behavior.
rakyll
added a commit
that referenced
this pull request
Jul 21, 2026
rakyll
pushed a commit
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #306
--harnessflag.Tested
Rerun the sequence in #306 without error.