Repository navigation
fix: make discussion answering model configurable - #6113
Closed
Haihan-Jiang wants to merge 3 commits into
Closed
Haihan-Jiang wants to merge 3 commits into
Haihan-Jiang wants to merge 3 commits into
Conversation
rohityan
added
models
Collaborator
|
Hi @Haihan-Jiang , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors before we can proceed with a review. |
rohityan
added
the
request clarification
copybara-service Bot
pushed a commit
that referenced
this pull request
Jul 13, 2026
Merge #6113 ## Summary - Configure the discussion answering agents through `LLM_MODEL_NAME` instead of hardcoding `gemini-3.5-flash`. - Let the GitHub workflow override both the answering model and Vertex location with repository variables. - Downgrade the default model from `gemini-3.5-flash` to `gemini-2.5-flash` because `gemini-3.5-flash` 404s on Vertex AI Search (#6104). - Document the new knobs. Fixes #6104 ## Testing - `git diff --check` - `python3.12 -m py_compile contributing/samples/adk_team/adk_answering_agent/settings.py contributing/samples/adk_team/adk_answering_agent/agent.py contributing/samples/adk_team/adk_answering_agent/gemini_assistant/agent.py` Co-authored-by: Kathy Wu <wukathy@google.com> COPYBARA_INTEGRATE_REVIEW=#6113 from Haihan-Jiang:codex/adk-python-answering-model-config aea24ea PiperOrigin-RevId: 947224603
Collaborator
|
Thank you @Haihan-Jiang for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit de4ac2d. Closing this PR as the changes are now in the main branch. |
FrigaZzz
pushed a commit
to FrigaZzz/adk-python
that referenced
this pull request
Aug 11, 2026
Merge google#6113 ## Summary - Configure the discussion answering agents through `LLM_MODEL_NAME` instead of hardcoding `gemini-3.5-flash`. - Let the GitHub workflow override both the answering model and Vertex location with repository variables. - Downgrade the default model from `gemini-3.5-flash` to `gemini-2.5-flash` because `gemini-3.5-flash` 404s on Vertex AI Search (google#6104). - Document the new knobs. Fixes google#6104 ## Testing - `git diff --check` - `python3.12 -m py_compile contributing/samples/adk_team/adk_answering_agent/settings.py contributing/samples/adk_team/adk_answering_agent/agent.py contributing/samples/adk_team/adk_answering_agent/gemini_assistant/agent.py` Co-authored-by: Kathy Wu <wukathy@google.com> COPYBARA_INTEGRATE_REVIEW=google#6113 from Haihan-Jiang:codex/adk-python-answering-model-config aea24ea PiperOrigin-RevId: 947224603
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLM_MODEL_NAMEinstead of hardcodinggemini-3.5-flash.Fixes #6104
Testing
git diff --checkpython3.12 -m py_compile contributing/samples/adk_team/adk_answering_agent/settings.py contributing/samples/adk_team/adk_answering_agent/agent.py contributing/samples/adk_team/adk_answering_agent/gemini_assistant/agent.py tests/unittests/contributing/test_adk_answering_agent_model_config.py/tmp/adk-python-pr6104-venv/bin/python -m pytest tests/unittests/contributing/test_adk_answering_agent_model_config.py/tmp/adk-python-pr6104-venv/bin/python -m pyink --check contributing/samples/adk_team/adk_answering_agent/settings.py contributing/samples/adk_team/adk_answering_agent/agent.py contributing/samples/adk_team/adk_answering_agent/gemini_assistant/agent.py tests/unittests/contributing/test_adk_answering_agent_model_config.py