docs: move the third Loop Agent label back into the Loop box - #2252
Merged
joefernandez merged 2 commits intoSep 23, 2026
Merged
joefernandez merged 2 commits into
joefernandez merged 2 commits into
Conversation
The Agent C outline for the Loop Agent column is a copy of the Parallel column's label and relied on a separate transform to sit in the Loop box. That line was removed before google#2249 merged, so the Loop box renders empty. Shift the path's starting point instead, so the position no longer depends on an extra attribute. The rest of the path is relative, so only the first coordinate changes.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joefernandez
approved these changes
Sep 23, 2026
joefernandez
left a comment
joefernandez
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix!
joefernandez
enabled auto-merge (squash)
September 23, 2026 05:00
zyantw
pushed a commit
to zyantw/adk-docs
that referenced
this pull request
Sep 24, 2026
…2252) The Agent C outline for the Loop Agent column is a copy of the Parallel column's label and relied on a separate transform to sit in the Loop box. That line was removed before google#2249 merged, so the Loop box renders empty. Shift the path's starting point instead, so the position no longer depends on an extra attribute. The rest of the path is relative, so only the first coordinate changes. Co-authored-by: Joe Fernandez <931947+joefernandez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2249.
On main the third box in the Loop Agent column of the Template workflows diagram is now empty.
The "Agent C" label there is a copy of the Parallel column's label outline, and in #2249 it used a
separate
transformattribute to move it into the Loop box. That line was removed by one of thereview suggestions before merge, so the label now renders at its original position, on top of the
Parallel column's "Agent C", and the Loop box shows nothing.
This change shifts the path's starting point instead of using a
transform. The rest of the pathuses relative commands, so only the first coordinate changes, and the position no longer depends on
a separate attribute. One line changes in
docs/assets/template_workflows.svg.Checked by rendering the SVG in Chrome: main shows an empty third Loop box; with this change it
reads "Agent C", and the render is pixel-identical to the version approved in #2249.
Before (adk.dev today):
After (this branch, local build):