Skip to content

docs(runtime): clarify filtered session history retention - #2244

Merged
joefernandez merged 3 commits into
google:mainfrom
baba9811:docs/redis-filtered-session-history
Sep 19, 2026
Merged

joefernandez merged 3 commits into
google:mainfrom
baba9811:docs/redis-filtered-session-history

Conversation

@baba9811

Copy link
Copy Markdown
Contributor

Clarifies that Python RunConfig.get_session_config limits the loaded event view while preserving stored history when new events are appended. This accompanies the Redis filtered-history preservation fix in google/adk-python.

Testing

  • mkdocs build --strict passes and indexes 235 pages. It reports an existing missing migration-page anchor at INFO level; this change adds no links.
  • mkdocs serve returns HTTP 200 and renders the clarification as part of the existing list item.
  • Verified the behavior with direct appends and Runner turns on Redis, memory, SQLite and SQLAlchemy SQLite.

@netlify

netlify Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for adk-docs-preview ready!

Name Link
🔨 Latest commit fa57fb5
🔍 Latest deploy log https://app.netlify.com/projects/adk-docs-preview/deploys/6aae0d66afc4080008a067fe
😎 Deploy Preview https://deploy-preview-2244--adk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joefernandez joefernandez left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review report

  • Review Score: 100
  • Overall assessment: 🟢 Low Risk
  • Summary reasoning: The three added sentences in docs/runtime/runconfig.md state that GetSessionConfig filters (num_recent_events, after_timestamp) only narrow the loaded view and that new events append to the full stored history. I verified this against every session service shipped in the current release, adk-python v2.9.1, and the claim is correct in each. The API referenced is released, not merged-but-unreleased.
  • Recommended action: No concerns, approve. The change adds accurate clarification to an already-correct bullet, touches no code samples, and introduces no new API surface. The only observation is stylistic (mild redundancy between the two new sentences), not a technical risk.
  • Number of lines changed: XS, 4
  • Number of files changed: 1

Verification detail

The changed text is at docs/runtime/runconfig.md:76-80, inside a section tagged "Supported in ADK: Python", which matches the fact that get_session_config exists only on Python's RunConfig: run_config.py:262-280.

Claim 1 — "These filters limit the loaded view without deleting stored events":

Claim 2 — "New events are appended to the stored history, preserving older events excluded from the loaded view":

  • In-memory: append_event appends to the canonical storage_session, even when the caller holds a filtered copy: in_memory_session_service.py:354.
  • Database: append_event inserts a new StorageEvent row and never rewrites the event table: database_session_service.py:976.
  • The Runner passes run_config.get_session_config straight into session_service.get_session() on the load path, so filtering is confined to the read: runners.py:895-900.

No risk items found. One optional, non-scoring wording note: "without deleting stored events" and "preserving older events excluded from the loaded view" say the same thing twice; the bullet could be tightened to a single sentence, e.g. These filters limit the loaded view only: stored events are not deleted, and new events are appended to the full stored history.

@joefernandez
joefernandez enabled auto-merge (squash) September 18, 2026 23:55

@joefernandez joefernandez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@joefernandez
joefernandez merged commit 9720c24 into google:main Sep 19, 2026
3 of 4 checks passed
zyantw pushed a commit to zyantw/adk-docs that referenced this pull request Sep 24, 2026
Co-authored-by: Joe Fernandez <931947+joefernandez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants