Name FileArtifactService in the artifact service list - #2162
Open
happyhuman wants to merge 1 commit into
Open
Conversation
Two prose lines enumerated only the in-memory and GCS services, both attributed to Python. Kotlin has had FileArtifactService, which persists artifacts to a local directory, since v0.4.0. The page already has a Kotlin tab and badge, so this is an omission in the enumeration rather than a missing snippet group. The androidMain FileArtifactServiceAndroid and its fromInternalFilesDir / fromExternalFilesDir factories are left out on purpose: this page is not Android-scoped and naming them would imply availability the JVM artifact does not have.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two prose lines on
docs/artifacts/index.mdlisted onlyInMemoryArtifactServiceandGcsArtifactServiceas available artifact services. Kotlin has had a third since v0.4.0 —FileArtifactService, which persists artifacts to a directory on the local filesystem.Why prose and not a tab
The page already has a Kotlin tab and is already Kotlin-badged. This is an omission in the enumeration of implementations, not a missing snippet group, so there is nothing to add a tab to.
Scope
FileArtifactServiceAndroidand thefromInternalFilesDir/fromExternalFilesDirfactories areandroidMain-only and are deliberately left out — this page is not Android-scoped, and naming them would imply availability the JVM artifact does not have.Phrasing follows the page's existing "(e.g.,
Xin Python, defined in ...)" pattern, attributing the class to Kotlin without claiming the other SDKs lack an equivalent.Verification
Ladder green (L0, L1, L2, L3, L5, L6); L4
runSnippetsSKIP — no such Gradle task in this repo. No code changed.Tracked as KT-29.