[DO NOT MERGE until 1.0 ships] Bump adk-docs to adk-kotlin 1.0.0 - #2152
Draft
happyhuman wants to merge 2 commits into
Draft
[DO NOT MERGE until 1.0 ships] Bump adk-docs to adk-kotlin 1.0.0#2152happyhuman wants to merge 2 commits into
happyhuman wants to merge 2 commits into
Conversation
KT-23. adk-docs compiles its Kotlin snippets against the pinned SDK, so no 1.0
feature can be documented until this pin moves. Prerequisite only - no snippets,
no prose about 1.0 features.
Moves the examples pin (core, webserver, processor, a2a) and the install
instructions readers copy from, which track the pin for the same reason they did
at 0.8.0: leaving them behind hands newcomers an SDK older than the snippets on
the same page.
THIS DOES NOT BUILD YET, and cannot until the artifacts are published:
> Could not find com.google.adk:google-adk-kotlin-core:1.0.0.
> Could not find com.google.adk:google-adk-kotlin-webserver:1.0.0.
> Could not find com.google.adk:google-adk-kotlin-a2a:1.0.0.
Maven Central carries 0.8.0 as the newest release for every artifact today, and
google/adk-kotlin has no v1.0.0 tag. The PR is a draft until the release lands.
Two comments that pinned third-party versions against adk-kotlin 0.8.0's
catalog - Ktor 2.3.13 and a2a-java-sdk-client 1.0.0.Final - now say the match
was made against 0.8.0 and needs re-checking, rather than restating it as though
it still held. A major release is exactly where a transitive version moves.
Also note the version string is assumed to be `1.0.0`. If the release is cut as
`1.0.0-rc.1` or similar, these five coordinates need to match it.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Missed on the first pass, and the reason is worth recording: the sweep used `google-adk-kotlin[a-z-]*:0\.8\.0`, whose character class has no digits, so it silently skipped `google-adk-kotlin-a2a` - the one artifact with a digit in its name. Every other coordinate matched, so the search looked exhaustive and was not. The corrected pattern is `google-adk-kotlin[a-z0-9-]*:[0-9]+\.[0-9]+\.[0-9]+`. Run repo-wide it now finds five live coordinates in the examples build file and seventeen in the docs, all at 1.0.0, and nothing left below it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge before adk-kotlin 1.0 is published. This PR pins versions that
do not exist yet, so the Kotlin examples project cannot resolve its
dependencies until the release lands. Opened as a draft deliberately;
earliest merge is 2026-09-02, and only once
1.0.0is on Maven Central.Summary
KT-23, the prerequisite that unblocks every 1.0 feature. adk-docs compiles its
Kotlin snippets against the pinned SDK, so nothing new can be documented until
this moves. No snippets and no 1.0 prose here — just the pin, so the review is
small and the risky part is the verification that has to happen after the
release.
examples/kotlin/build.gradle.kts: core, webserver, processor and a2a0.8.0 → 1.0.0.
docs/get-started/kotlin.md,docs/get-started/installation.md,docs/agents/models/litert-lm.md,docs/a2a/quickstart-consuming-kotlin.md. These track the pin for the samereason they did at 0.8.0 — leaving them behind hands a newcomer an SDK older
than the snippets on the same page.
Seventeen coordinates in docs, five in the build file, and nothing left below
1.0.0 anywhere in the repo.
What is deliberately not bumped
Kotlin vX.Y.Zsupport badges (~40 of them). Those record the releasea feature landed in, not the current version — bumping them would assert
that e.g.
LlmAgentfirst appeared in 1.0. Same for the "Since adk-kotlin0.7.0" comment in
CountInvocationPlugin.kt.The API reference has to ship with this, and cannot be built yet
docs/api-reference/kotlin/is generated Dokka output — 1,721 files — and itsindex still renders 0.5.0, five releases behind. Leaving it means "adk-docs
is on 1.0" would be false the moment this merges, so it belongs in this PR, not
a follow-up.
It cannot be produced today, for the same reason the pin cannot be compiled:
git ls-remote --tags https://github.com/google/adk-kotlinreturnsv0.8.0asthe newest tag; there is no
v1.0.0to clone. The generator also needsANDROID_HOMEwithplatforms;android-34, because adk-kotlin hasandroidMainsource sets — so whoever runs it needs the Android command-line tools installed
first.
This does not build yet, and that is expected
Maven Central lists 0.8.0 as the newest release for every
google-adk-kotlin-*artifact today, and
google/adk-kotlinhas nov1.0.0tag. Nothing is wrongwith the change; the artifacts simply are not there.
Note that CI will go green anyway, and that is not evidence. The
kotlin-snippets-pr-checkjob only builds.ktfiles changed in the PR, andthis PR changes none — so it will compile nothing at all. Exactly the gap that
let the 0.8.0 bump (#2143) merge with a snippet that no longer compiled.
Pre-merge checklist
Once
1.0.0is on Maven Central, before merging:1.0.0and not1.0.0-rc.1or similar — five coordinates here assume it.
JAVA_HOME=<jdk17> ./tools/kotlin-snippets/runner.sh build— the fullregression, not the changed-files subset. All 29 registered snippets.
JAVA_HOME=<jdk17> ./tools/kotlin-snippets/runner.sh lint.Ktor
2.3.13anda2a-java-sdk-client:1.0.0.Final. A major release iswhere a transitive version moves.
snippets survive. At 0.8.0,
BaseTool.runwidened itsargsfromMap<String, Any>toMap<String, Any?>and brokeMultiAgentExample.kt;a major release is likelier to carry more.
verify_snippets.pyacross the pages with Kotlin tabs.bash tools/kotlin-api-docs/generate.sh 1.0.0(needs JDK 17 andANDROID_HOMEwithplatforms;android-34). Confirm afterwards thatdocs/api-reference/kotlin/index.htmlrenders1.0.0, not0.5.0.As of today,
adk-kotlinmainsits 13 commits pastv0.8.0and none of themtouch
core/src/commonMain,core/src/jvmMain,a2a/srcorintegrations/src— so there is no known breakage yet. That is a snapshot, not a guarantee: 1.0
has not been cut.
Interaction with the open Kotlin PRs
Three PRs in flight add or touch Kotlin dependencies and will need the same
version once they land:
google-adk-kotlin-integrations:0.8.0. That line does not existon
main, so it is not bumped here — whichever of the two merges second has toreconcile it.
regression above.
Verification
Honestly: none is possible today beyond what is stated. The only command run was
the compile, and it failed with the resolution errors quoted above — which is the
correct outcome for an unpublished version, and the reason this is a draft.
One process note, since it nearly cost this PR a file: the first sweep used
google-adk-kotlin[a-z-]*:0\.8\.0. That character class excludes digits, so itskipped
google-adk-kotlin-a2a— the only artifact with a digit in its name —while matching everything else, which made the search look complete. Commit
c0a56767fixes the coordinate and records the corrected pattern:google-adk-kotlin[a-z0-9-]*:[0-9]+\.[0-9]+\.[0-9]+. Worth reusing at the nextbump.