This repository was archived by the owner on Apr 19, 2026. It is now read-only.
Forest vs tree#2
Open
deepakpandita57 wants to merge 13 commits into
Open
Conversation
…sion to save storage space
…est vs tree paper
…he former method is deprecated
pk-at-g
reviewed
Feb 19, 2026
pk-at-g
reviewed
Feb 19, 2026
pk-at-g
reviewed
Feb 19, 2026
Added missing docstrings, cleaned up irrelevant docstrings, and split code into multiple lines to avoid exceeding 80 chars.
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
pk-at-g
reviewed
Feb 22, 2026
|
Hi Deepak,
I’m going to take Samay and Mamadou out for dinner tomorrow, to celebrate submission of our paper. It’s also Mamadou’s birthday and Samay is leaving at the end of the week. Would you like to join us (on me)? We haven’t celebrated our conference attendances (or even acceptances, have we?)
C
From: Deepak Pandita ***@***.***>
Date: Wednesday, February 25, 2026 at 4:46 PM
To: google-research/vet ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [google-research/vet] Forest vs tree (PR #2)
@deepakpandita57 commented on this pull request.
________________________________
In cat_machine_contest_metrics.py<#2 (comment)>:
+ machine1: np.ndarray,
+ machine2: np.ndarray,
+) -> tuple[float, float]:
+ """Compute accuracy relative to human labels.
+
+ Args:
+ human: A list of human scores.
+ machine1: A list of machine scores.
+ machine2: Another list of machine scores.
+
+ Returns:
+ A pair of accuracy scores, for machines 1 and 2, relative to
+ human scores.
+ """
+
+ num_categories = np.max(np.concatenate((
Yes, I can use stack and max here.
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQNUTLXPLMDH5RAIL5X5VT4NYJZFAVCNFSM6AAAAACUZ4H2ZOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNJXGE3TIOJXGE>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
pk-at-g
reviewed
Mar 2, 2026
| _COMPUTE_ACTUAL_P_VALUES = flags.DEFINE_boolean( | ||
| "compute_actual_p_values", | ||
| False, | ||
| "If true use categorical params directly to compute metrics and p-values.", |
There was a problem hiding this comment.
Give a pointer to the formula that would be used to compute an "actual" (analytic?) p-value.
Author
There was a problem hiding this comment.
This does not refer to the analytic p-values. Here it means that the categorical parameters sampled are directly used for p-value calculation.
pk-at-g
reviewed
Mar 2, 2026
pk-at-g
reviewed
Mar 2, 2026
pk-at-g
reviewed
Mar 2, 2026
pk-at-g
reviewed
Mar 2, 2026
pk-at-g
reviewed
Mar 2, 2026
pk-at-g
reviewed
Mar 2, 2026
| n_items: int = 1000, | ||
| k_responses: int = 5, | ||
| m_categories: int = 3, | ||
| alpha: List[float] = [0.6, 0.1, 0.3], |
There was a problem hiding this comment.
Why these default values? Note: they're different from the _ALPHA flag default values.
Author
There was a problem hiding this comment.
No particular reason, except this is the fraction of categories in the DICES dataset. I have changed the flag values to match these, but I'm open to your suggestions.
pk-at-g
reviewed
Mar 2, 2026
pk-at-g
reviewed
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes: