verify: Add test demonstrating negative start state crash#247
Open
copybara-service[bot] wants to merge 1 commit into
Open
verify: Add test demonstrating negative start state crash#247copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Negative state IDs (other than `kNoStateId`) currently bypass the initial bounds check (`start >= ns`) because `start` and `ns` are signed. This leads to crashes later in `ComputeProperties` (which calls `DfsVisit`) when it attempts to use the negative start state ID as an index into vectors. Use `EXPECT_DEATH` to verify the crash occurs. PiperOrigin-RevId: 944930505
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify: Add test demonstrating negative start state crash
Negative state IDs (other than
kNoStateId) currently bypass theinitial bounds check (
start >= ns) becausestartandnsaresigned. This leads to crashes later in
ComputeProperties(which callsDfsVisit) when it attempts to use the negative start state ID as anindex into vectors.
Use
EXPECT_DEATHto verify the crash occurs.