verify: Reject negative FST start state IDs#246
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
Negative state IDs (other than `kNoStateId`) were previously passing the initial bounds check because `start` and `ns` are signed, making negative values smaller than `ns` but still invalid as state IDs. This led to crashes downstream in `ComputeProperties` (and potentially other algorithms). Explicitly validate that the `start` state ID is non-negative (or equal to `kNoStateId`), returning an `InvalidArgumentError` if it is invalid. PiperOrigin-RevId: 944930504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify: Reject negative FST start state IDs
Negative state IDs (other than
kNoStateId) were previously passing theinitial bounds check because
startandnsare signed, makingnegative values smaller than
nsbut still invalid as state IDs. Thisled to crashes downstream in
ComputeProperties(and potentially otheralgorithms).
Explicitly validate that the
startstate ID is non-negative (or equalto
kNoStateId), returning anInvalidArgumentErrorif it is invalid.