Skip to content

fix(patch): cherry-pick f47d6c6 to release/v0.53.0-pr-28566 [CONFLICTS] - #28610

Merged
DavidAPierce merged 2 commits into
release/v0.53.0-pr-28566from
hotfix/v0.53.0/0.53.1/stable/cherry-pick-f47d6c6/pr-28566
Jul 31, 2026
Merged

fix(patch): cherry-pick f47d6c6 to release/v0.53.0-pr-28566 [CONFLICTS]#28610
DavidAPierce merged 2 commits into
release/v0.53.0-pr-28566from
hotfix/v0.53.0/0.53.1/stable/cherry-pick-f47d6c6/pr-28566

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit f47d6c6 to patch version v0.53.0 in the stable release to create version 0.53.1.

⚠️ Merge Conflicts Detected

This cherry-pick resulted in merge conflicts that need manual resolution.

🔧 Next Steps:

  1. Review the conflicts: Check out this branch and review the conflict markers
  2. Resolve conflicts: Edit the affected files to resolve the conflicts
  3. Test the changes: Ensure the patch works correctly after resolution
  4. Update this PR: Push your conflict resolution

📋 Files with conflicts:

The commit has been created with conflict markers for easier manual resolution.

🚨 Important:

  • Do not merge this PR until conflicts are resolved
  • The automated patch release will trigger once this PR is merged

…c empty response guidance (#28566)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
# Conflicts:
#	packages/core/src/core/geminiChat.ts
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

📊 PR Size: size/XL

  • Lines changed: 2367
  • Additions: +2285
  • Deletions: -82
  • Files changed: 28

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cherry-picks a critical fix to improve the robustness of stream handling within the Gemini CLI. It addresses issues where empty or malformed responses could lead to inconsistent application states. By implementing granular error categorization, automatic history restoration, and enhanced telemetry, the changes ensure that the system can gracefully recover from transient API issues and provide clearer feedback to the user.

Highlights

  • Improved Error Handling: Enhanced the handling of InvalidStreamError across the CLI and core packages to provide more specific guidance and categorization for different failure types.
  • History Rollback: Implemented automatic history rollback mechanisms to ensure the chat state remains consistent when a stream fails.
  • Telemetry Updates: Added semantic validation error tracking to telemetry to better monitor and analyze stream failure patterns.
  • Retry Logic: Introduced context-aware retries with system instruction nudging to help the model recover from silent failure loops.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

70 tests passed successfully on gemini-3-flash-preview.

🧠 Model Steering Guidance

This PR modifies files that affect the model's behavior (prompts, tools, or instructions).

  • ⚠️ Consider adding Evals: No behavioral evaluations (evals/*.eval.ts) were added or updated in this PR. Consider adding a test case to verify the new behavior and prevent regressions.
  • 🚀 Maintainer Reminder: Please ensure that these changes do not regress results on benchmark evals before merging.

This is an automated guidance message triggered by steering logic signatures.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive handling and propagation of InvalidStreamError details to the UI, providing specific guidance for empty responses (such as safety blocks, token limit exhaustion, or thinking-only responses). It also implements context-aware retries with on-retry nudging, history rollback on stream failures to prevent un-responded turns from polluting the chat history, and distinct telemetry tracking for semantic validation errors. However, a critical issue was found in packages/core/src/core/geminiChat.ts where unresolved git merge conflict markers remain in the code, which will cause compilation failures.

Note: Security Review did not run due to the size of the PR.

Comment thread packages/core/src/core/geminiChat.ts Outdated
@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Jul 31, 2026
@github-actions

Copy link
Copy Markdown

Size Change: +14 kB (+0.04%)

Total Size: 35.2 MB

Filename Size Change
./bundle/chunk-4JV2GXZS.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-EMOPX43A.js 0 B -13 kB (removed) 🏆
./bundle/chunk-EVDOP3GM.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-KCJ6NB6X.js 0 B -3.77 kB (removed) 🏆
./bundle/chunk-LYNYCF2X.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-ONES3WBR.js 0 B -16.6 MB (removed) 🏆
./bundle/chunk-UJIMJADY.js 0 B -661 kB (removed) 🏆
./bundle/chunk-WW3HKUQ5.js 0 B -3.65 MB (removed) 🏆
./bundle/core-R6YEICAO.js 0 B -50.1 kB (removed) 🏆
./bundle/devtoolsService-UKERXZPF.js 0 B -147 kB (removed) 🏆
./bundle/gemini-6GACDWLN.js 0 B -590 kB (removed) 🏆
./bundle/interactiveCli-WMPAD4PR.js 0 B -1.3 MB (removed) 🏆
./bundle/liteRtServerManager-ZAZ45S6M.js 0 B -2.08 kB (removed) 🏆
./bundle/oauth2-provider-YWVBZOIM.js 0 B -9.12 kB (removed) 🏆
./bundle/chunk-27IDHNYH.js 3.77 kB +3.77 kB (new file) 🆕
./bundle/chunk-3FFD6IT3.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-42PKRUVC.js 3.65 MB +3.65 MB (new file) 🆕
./bundle/chunk-77WXV4HD.js 13 kB +13 kB (new file) 🆕
./bundle/chunk-G3UTZQDW.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-G576VCVT.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-HDN5XJIC.js 661 kB +661 kB (new file) 🆕
./bundle/chunk-RMHZ3YDQ.js 16.6 MB +16.6 MB (new file) 🆕
./bundle/core-F44YWZ47.js 50.5 kB +50.5 kB (new file) 🆕
./bundle/devtoolsService-A4W6Y2PI.js 147 kB +147 kB (new file) 🆕
./bundle/gemini-GYELODKF.js 593 kB +593 kB (new file) 🆕
./bundle/interactiveCli-3TXRDIJH.js 1.31 MB +1.31 MB (new file) 🆕
./bundle/liteRtServerManager-JITP5FJ5.js 2.08 kB +2.08 kB (new file) 🆕
./bundle/oauth2-provider-V3GUM567.js 9.12 kB +9.12 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-L5V3KIDT.js 1.62 kB 0 B
./bundle/chunk-TUDYL3X4.js 40.3 kB 0 B
./bundle/cleanup-YDHE3VDA.js 0 B -902 B (removed) 🏆
./bundle/devtools-TYCPOPV3.js 683 kB 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.38 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/https-proxy-agent-AVGR4LHR.js 490 B 0 B
./bundle/multipart-parser-E7RMVJWU.js 11.7 kB 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 5.29 kB 0 B
./bundle/sandbox-macos-permissive-proxied.sb 5.58 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.3 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.5 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.75 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 4.96 kB 0 B
./bundle/src-65GKNWUJ.js 45.4 kB 0 B
./bundle/src-U45KTUYT.js 45.7 kB 0 B
./bundle/src-XZYPU6PJ.js 352 kB 0 B
./bundle/start-6IWK6AYE.js 0 B -622 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/worker/worker-entry.js 363 kB 0 B
./bundle/cleanup-RGNZRKGN.js 902 B +902 B (new file) 🆕
./bundle/start-U6KY42FH.js 622 B +622 B (new file) 🆕

compressed-size-action

@DavidAPierce
DavidAPierce enabled auto-merge (squash) July 31, 2026 20:24
@DavidAPierce
DavidAPierce merged commit 983af5d into release/v0.53.0-pr-28566 Jul 31, 2026
29 checks passed
@DavidAPierce
DavidAPierce deleted the hotfix/v0.53.0/0.53.1/stable/cherry-pick-f47d6c6/pr-28566 branch July 31, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl An extra large PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants