Remove apply_adaptive_source function. Replaced by proper internal boundary conditions.#2249
Merged
Merged
Conversation
0bce933 to
acbc2f5
Compare
…undary conditions. The `apply_adaptive_source` function, which was used to add adaptive source terms based on internal boundary conditions, has been removed from `internal_boundary_conditions.py`. Its call in `calc_coeffs.py` has also been removed, along with the associated test case. PiperOrigin-RevId: 942195589
acbc2f5 to
a19fc8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove apply_adaptive_source function. Replaced by proper internal boundary conditions.
The
apply_adaptive_sourcefunction, which was used to add adaptive source terms based on internal boundary conditions, has been removed frominternal_boundary_conditions.py. Its call incalc_coeffs.pyhas also been removed, along with the associated test case.