Skip to content

Fix the issue #17#18

Open
GCorbel wants to merge 3 commits into
goodwill:masterfrom
GCorbel:master
Open

Fix the issue #17#18
GCorbel wants to merge 3 commits into
goodwill:masterfrom
GCorbel:master

Conversation

@GCorbel

@GCorbel GCorbel commented Aug 30, 2013

Copy link
Copy Markdown

It works for me

@chalmagean

Copy link
Copy Markdown

it should probably be find(:css, drop_container).find(:css, ".select2-result-label").click since the span is used to match the searched text

@GCorbel

GCorbel commented Sep 2, 2013

Copy link
Copy Markdown
Author

Both are working.

I made a benchmark and this is the result :

select2-result-label  1.150000   0.510000   1.660000 (  3.041824)
select2-match  1.050000   0.440000   1.490000 (  2.712075)

So, for speed, it's better to use "select2-match". Do you see another reason than speed?

@chalmagean

Copy link
Copy Markdown

select2-match is empty, unless you do a search

@GCorbel

GCorbel commented Sep 2, 2013

Copy link
Copy Markdown
Author

I did the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants