Dividerの修正 - #134
Merged
Merged
Conversation
added 4 commits
August 21, 2025 14:45
- 水平方向の破線スタイルを追加 - 垂直方向の破線スタイルを保持
- Emphasis、LineStyle、Directionストーリーの引数を統一 - Dividerコンポーネントのプロパティをargsで展開
- テストデータ定数を追加 - テストヘルパー関数を導入 - 各テストケースをデータ駆動型に変更 - テストの可読性を向上
- DividerコンポーネントをFigmaに接続 - プロパティのマッピングを定義 - コード例をFigma用に設定
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the dashed line style was not being applied to the Divider component. The fix involves uncommenting the compound variants for dashed styles and includes comprehensive test improvements and Storybook adjustments.
- Uncommented the compound variants for dashed line styles in both horizontal and vertical directions
- Refactored tests to use more structured, maintainable patterns with test data constants and helper functions
- Updated Storybook stories to use proper Story type with args and render functions
- Added Figma Connect integration for design-code synchronization
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/ui/divider/index.tsx | Fixed dashed line style by uncommenting compound variants |
| src/components/ui/divider/index.test.tsx | Comprehensive test refactoring with improved structure and coverage |
| src/components/ui/divider/index.stories.tsx | Updated Storybook stories to use proper Story format with args |
| src/components/ui/divider/index.figma.tsx | Added new Figma Connect integration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
NotionのFBに伴う修正
https://www.notion.so/goodpatch-design-div/Divider-d6f037a7592246c48b438c7357b3c997?source=copy_link
変更内容
動作確認
pnpm lintを実行pnpm build:packageを実行してパッケージが正常にビルドされることを確認pnpm testを実行してテストがすべて成功することを確認関連 Issue