IconButtonの修正 - #123
Merged
Merged
Conversation
- IconButtonのストーリーでargsを使用してプロパティを適用 - アイコンボタンの説明を更新 - スタイルの改善により、カーソルをポインタに設定
…、関連するスタイルを更新 - IconButtonのテーマオプションを「neutral」に変更 - スタイルのクラス名を「neutral」に合わせて更新 - ストーリー内のテーマに関するテストを修正
- IconButtonコンポーネントのvariantオプションから「outline-solid」を削除し、「outline」を追加
- IconButtonコンポーネントにneutralテーマを追加 - isDisabledプロパティの処理を改善 - IconButtonのテストケースを新規作成
- IconButtonコンポーネントの基本レンダリングテストを追加 - バリアントスタイリングのテストを追加 - サイズバリアントのテストを追加 - ローディング状態のテストを追加 - 無効状態のテストを追加 - ユーザーインタラクションのテストを追加 - アクセシビリティのテストを追加 - エッジケースのテストを追加 - Refフォワーディングのテストを追加
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
Refactors the IconButton component to improve styling consistency and API design. The changes align with design system guidelines and improve code maintainability through CVA reorganization.
- Replaced "secondary" theme with "neutral" theme across all variants
- Updated color schemes and removed shadow-sm from various states
- Added comprehensive test coverage and improved Storybook documentation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/ui/icon-button/item.json | Updated component description to better describe usage |
| src/components/ui/icon-button/index.tsx | Major refactor of CVA styles, theme changes, and prop improvements |
| src/components/ui/icon-button/index.test.tsx | Added comprehensive test suite covering all variants and edge cases |
| src/components/ui/icon-button/index.stories.tsx | Updated Storybook stories to reflect theme changes and improved structure |
| src/components/ui/icon-button/index.figma.tsx | Added neutral theme mapping for Figma integration |
…ral」に変更 - IconButtonコンポーネントのテーマを「neutral」に変更 - Modalコンポーネントのテーマを「neutral」に変更
ore0
reviewed
Aug 14, 2025
| [ | ||
| "inline-flex items-center justify-center whitespace-nowrap rounded-action", | ||
| "ring-offset-background transition-colors focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-[var(--color-ring-normal)] focus-visible:ring-offset-2", | ||
| "relative cursor-pointer antialiased", |
There was a problem hiding this comment.
antialiasedの定義をここでカットすればこのPRはマージしても問題なしです！
- "antialiased"クラスを削除し、スタイルを簡素化
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
以下指摘事項含めて再確認
https://www.notion.so/goodpatch-design-div/Icon-Button-454a13d0d11046f8b517c04ccd59cde4?source=copy_link
変更内容
動作確認
pnpm lintを実行pnpm buildを実行してプロジェクトが正常にビルドされることを確認pnpm testを実行してテストがすべて成功することを確認関連 Issue