Conversation
- Badgeコンポーネントのサイズオプションを更新 - バリエーションの選択肢を追加 - ストーリーの実装をリファクタリング
- バッジの大きさ「lg」のパディングを修正 - 使用例のバリエーションを「status」から「variant」に変更
- Badgeのサイズクラスを修正 - サイズに応じたバリアントのテストを追加 - 不要なテストケースを削除 - テストの可読性を向上
- BadgeコンポーネントをFigmaに接続 - プロパティのマッピングを設定 - コード例をFigmaに表示するための関数を追加
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Badge component by simplifying the size system, renaming the status prop to variant, and adding Figma Connect integration. The changes streamline the API while maintaining essential functionality.
Key Changes
- Simplified size system from 7 sizes (x5s, x4s, x3s, x2s, xs, sm, md) to 4 sizes (xs, sm, md, lg)
- Renamed
statusprop tovariantwith values "normal" and "emphasis" instead of "info", "success", and "negative" - Added Figma Connect integration for design-to-code workflow
- Updated registry configuration and documentation
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/ui/badge/index.tsx | Main component refactoring with simplified size system and variant prop |
| src/components/ui/badge/index.test.tsx | Updated test suite to match new API and size system |
| src/components/ui/badge/index.stories.tsx | Storybook stories updated for new props and proper Story type usage |
| src/components/ui/badge/index.figma.tsx | New Figma Connect integration file |
| registry.json | Registry configuration updates and reordering |
| public/r/tooltip.json | New tooltip component registry entry |
| public/r/registry.json | Public registry configuration updates |
| public/r/badge.json | Badge component registry entry with updated content |
| README.md | Documentation update showing Figma Code Connect implementation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ore0
approved these changes
Aug 13, 2025
Member
Author
|
調べたんですがどこからこの変化がきているのかはよくわからなかってです汗 
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
以下の指摘事項をもとに調整
変更内容
動作確認
pnpm lintを実行pnpm buildを実行してプロジェクトが正常にビルドされることを確認pnpm testを実行してテストがすべて成功することを確認関連 Issue