Fix jpeg capture cancelling context - #86
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes unreliable JPEG still captures by ensuring the request context remains active until the response body is fully read, preventing truncated JPEG data and downstream decode failures.
Changes:
- Refactors JPEG capture to first download raw bytes, then decode (avoids premature context cancellation).
- Updates
SaveJPEGto write server-provided JPEG bytes directly and adds JPEG-specific errors/constants. - Adjusts and expands tests to cover non-JPEG responses and slow/trickled response bodies.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cameras.go | Refactors GetJPEG/SaveJPEG to use a shared byte-fetch helper and changes fetch/timeout/error handling. |
| cameras_types.go | Adds new JPEG-related error values and constants used by the new fetch/write logic. |
| cameras_internal_test.go | Updates tests to validate new JPEG fetch behavior and new error conditions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Restore configurable Timeout/JPEGRetries, use O_EXCL for SaveJPEG, and avoid reading full bodies on non-OK responses. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JPEG captures were not working well because of premature context cancellation. This resolves it.