Fix MinDistanceToShapeIndexTarget.capBound returning antipodal Cap - #295
Open
joshua-zingale-rincon wants to merge 1 commit into
Open
Fix MinDistanceToShapeIndexTarget.capBound returning antipodal Cap#295joshua-zingale-rincon wants to merge 1 commit into
joshua-zingale-rincon wants to merge 1 commit into
Conversation
…olang#293) This aligns the implementation with that of the reference C++ implementation: S2Cap S2MinDistanceShapeIndexTarget::GetCapBound() { return S2ShapeIndexRegion(index_).GetCapBound(); } This also adds an end-to-end EdgeQuery test that would have caught this error. Fixes GitHub Issue: golang#293
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
joshua-zingale-rincon
marked this pull request as draft
August 3, 2026 19:25
joshua-zingale-rincon
marked this pull request as ready for review
August 3, 2026 19:31
|
Upvote! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
capBound()implementation onMinDistanceToShapeIndexTarget, which previously calculated the antipodal Cap bound, including also a test that failed on the parent commit. The fix aligns with the C++ implementation.Closes #293 (which is tested in the added test).