[PWI-1849][Henrico] feat!: add thread-safe config implementation and upgrade to gomod - #1
Merged
Conversation
tejasjadhav
requested changes
Jul 30, 2025
Collaborator
|
question: Do we need to update the README as well? |
Collaborator
Author
oh yeah, turns out we don't have readme. Let me update it as well |
ricoferdian-gtf
force-pushed
the
PWI-1849
branch
2 times, most recently
from
August 1, 2025 03:56
81a4454 to
875a251
Compare
Collaborator
Author
|
will add readme at the very end |
…s not have thread safety in place
tejasjadhav
requested changes
Aug 1, 2025
tejasjadhav
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Current config map cache implementation is not thread-safe, concurrent map write could trigger fatal panic. The goal of this change is to implement thread-safe config map by using mutex approach.
Minimal changes is recommended to ensure seamless integration with latest goconfig library on client side.
Feature changes
Chores
Notes