fix: 改进 setup-signing.sh 钥匙串指引和配对向导指示灯文案 - #8
Open
simonzhangs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么
修复两处新用户首次配置时容易困惑的文案问题:
1.
scripts/setup-signing.sh:钥匙串步骤指引缺少「点'证书'类别」的提示,用户打开钥匙串访问后默认看到的是「密码」类别,找不到「MiRemote Dev」证书。2.
Sources/MiRemote/UI/OnboardingWizard.swift:配对指示灯描述误导——小米蓝牙遥控器 2 Pro 进入配对模式时指示灯不会闪烁,原文案「不闪说明没按够 3 秒或电量不足」让用户反复尝试。改动类型
验证
./build.sh && .build/miremote --self-test全绿(仅改文案,无运行时行为变更)bash -n scripts/*.sh语法通过实机验证说明:
setup-signing.sh:macOS 26.0 + LibreSSL 3.3.6,已实机跑通脚本,证书生成、p12 打包、钥匙串导入三步全绿。
OnboardingWizard.swift:仅文案改动,无运行时行为变更,
--self-test800+ 项全绿。补充说明
两处问题均来自本人首次配置 MiRemote 的真实体验。小米蓝牙遥控器 2 Pro 的指示灯行为已通过实机操作确认(长按 3 秒后指示灯不闪,但去系统蓝牙设置中能找到新设备并成功连接)。