Skip to content

ak-platform-keyring: don't return expired cache entries - #1750

Merged
BeryJu merged 3 commits into
mainfrom
ak-cache-bug
Oct 23, 2026
Merged

BeryJu merged 3 commits into
mainfrom
ak-cache-bug

Conversation

@emilburzo

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.77465% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.44%. Comparing base (396b59c) to head (46f7387).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ak-platform-keyring/src/cache.rs 89.79% 0 Missing and 5 partials ⚠️
ak-agent/src/grpc/agent_cache.rs 98.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
+ Coverage   50.02%   50.44%   +0.41%     
==========================================
  Files         211      211              
  Lines       22212    22353     +141     
  Branches    16934    17075     +141     
==========================================
+ Hits        11112    11275     +163     
+ Misses      10710    10681      -29     
- Partials      390      397       +7     
Flag Coverage Δ
rs-e2e-24.04 33.69% <0.00%> (-0.04%) ⬇️
rs-e2e-25.10 10.54% <0.00%> (-0.02%) ⬇️
rs-e2e-26.04 10.54% <0.00%> (-0.03%) ⬇️
rs-macos-26-ak-agent 43.01% <98.92%> (+2.65%) ⬆️
rs-macos-26-ak-agent-desktop 0.38% <0.00%> (-0.01%) ⬇️
rs-macos-26-ak-api-cli 100.00% <ø> (ø)
rs-macos-26-ak-api-cli-gen 66.71% <ø> (ø)
rs-macos-26-ak-browser-support 23.68% <ø> (ø)
rs-macos-26-ak-cli 19.18% <ø> (ø)
rs-macos-26-ak-flow-executor 13.07% <ø> (ø)
rs-macos-26-ak-meta 0.00% <ø> (ø)
rs-macos-26-ak-meta-macros 0.00% <ø> (ø)
rs-macos-26-ak-platform 67.38% <ø> (-0.05%) ⬇️
rs-macos-26-ak-platform-authz 0.00% <ø> (ø)
rs-macos-26-ak-platform-facts 81.40% <ø> (ø)
rs-macos-26-ak-platform-keyring 81.51% <89.79%> (+15.87%) ⬆️
rs-macos-26-ak-sysd 38.53% <ø> (ø)
rs-ubuntu-26.04-ak-agent 44.48% <98.92%> (+4.13%) ⬆️
rs-ubuntu-26.04-ak-agent-desktop 0.38% <0.00%> (-0.01%) ⬇️
rs-ubuntu-26.04-ak-api-cli 100.00% <ø> (ø)
rs-ubuntu-26.04-ak-api-cli-gen 66.71% <ø> (ø)
rs-ubuntu-26.04-ak-browser-support 23.68% <ø> (ø)
rs-ubuntu-26.04-ak-cli 19.18% <ø> (ø)
rs-ubuntu-26.04-ak-flow-executor 13.07% <ø> (ø)
rs-ubuntu-26.04-ak-meta 0.00% <ø> (ø)
rs-ubuntu-26.04-ak-meta-macros 0.00% <ø> (ø)
rs-ubuntu-26.04-ak-nss 77.37% <ø> (ø)
rs-ubuntu-26.04-ak-pam 0.00% <ø> (ø)
rs-ubuntu-26.04-ak-platform 67.23% <ø> (ø)
rs-ubuntu-26.04-ak-platform-authz 0.00% <ø> (ø)
rs-ubuntu-26.04-ak-platform-facts 80.78% <ø> (ø)
rs-ubuntu-26.04-ak-platform-keyring 68.33% <89.79%> (+15.25%) ⬆️
rs-ubuntu-26.04-ak-sysd 37.17% <ø> (ø)
rs-ubuntu-26.04-arm-ak-agent 44.48% <98.92%> (+4.13%) ⬆️
rs-ubuntu-26.04-arm-ak-agent-desktop 0.38% <0.00%> (-0.01%) ⬇️
rs-ubuntu-26.04-arm-ak-api-cli 100.00% <ø> (ø)
rs-ubuntu-26.04-arm-ak-api-cli-gen 66.71% <ø> (ø)
rs-ubuntu-26.04-arm-ak-browser-support 23.68% <ø> (ø)
rs-ubuntu-26.04-arm-ak-cli 19.18% <ø> (ø)
rs-ubuntu-26.04-arm-ak-flow-executor 13.07% <ø> (ø)
rs-ubuntu-26.04-arm-ak-meta 0.00% <ø> (ø)
rs-ubuntu-26.04-arm-ak-meta-macros 0.00% <ø> (ø)
rs-ubuntu-26.04-arm-ak-nss 77.37% <ø> (ø)
rs-ubuntu-26.04-arm-ak-pam 0.00% <ø> (ø)
rs-ubuntu-26.04-arm-ak-platform 67.19% <ø> (ø)
rs-ubuntu-26.04-arm-ak-platform-authz 0.00% <ø> (ø)
rs-ubuntu-26.04-arm-ak-platform-facts 80.78% <ø> (ø)
rs-ubuntu-26.04-arm-ak-platform-keyring 68.33% <89.79%> (+15.25%) ⬆️
rs-ubuntu-26.04-arm-ak-sysd 37.17% <ø> (ø)
rs-windows-2025-ak-agent 41.60% <98.92%> (+4.47%) ⬆️
rs-windows-2025-ak-agent-desktop 0.37% <0.00%> (-0.01%) ⬇️
rs-windows-2025-ak-api-cli 100.00% <ø> (ø)
rs-windows-2025-ak-api-cli-gen 66.71% <ø> (ø)
rs-windows-2025-ak-browser-support 23.68% <ø> (ø)
rs-windows-2025-ak-cli 19.18% <ø> (ø)
rs-windows-2025-ak-flow-executor 13.07% <ø> (ø)
rs-windows-2025-ak-meta 0.00% <ø> (ø)
rs-windows-2025-ak-meta-macros 0.00% <ø> (ø)
rs-windows-2025-ak-platform 63.34% <ø> (ø)
rs-windows-2025-ak-platform-authz 0.00% <ø> (ø)
rs-windows-2025-ak-platform-facts 78.89% <ø> (ø)
rs-windows-2025-ak-platform-keyring 82.90% <89.79%> (+6.65%) ⬆️
rs-windows-2025-ak-sysd 36.09% <ø> (ø)
rs-windows-2025-ee/wcp 44.29% <0.00%> (-0.04%) ⬇️
swift 3.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@authentik-automation

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://pr-1750--authentik-pkg.netlify.app

@authentik-automation
authentik-automation Bot temporarily deployed to pull request October 22, 2026 16:38 Inactive
Comment thread ak-platform-keyring/src/cache.rs Resolved
Signed-off-by: Emil Burzo <contact@emilburzo.com>
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in authentik Core Oct 23, 2026
@BeryJu
BeryJu merged commit 2080952 into main Oct 23, 2026
112 checks passed
@BeryJu
BeryJu deleted the ak-cache-bug branch October 23, 2026 11:27
@github-project-automation github-project-automation Bot moved this from In Progress to Done in authentik Core Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants