Skip to content

test: fix flaky TestDeps by using group output #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmaerten wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

test: fix flaky TestDeps by using group output #2926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,12 @@ func TestDeps(t *testing.T) {
WithExecutorOptions(
task.WithDir("testdata/deps"),
task.WithSilent(true),
// Deps run in parallel and, with the default interleaved output,
// their sub-line writes (echo writes the content and the newline
// separately) can interleave into a garbled buffer. Group output
// flushes each command atomically, keeping every line intact. The
// set of lines asserted (via PPSortedLines) is unchanged.
task.WithOutputStyle(ast.Output{Name: "group"}),
),
WithPostProcessFn(PPSortedLines),
)
Expand Down
Loading