Repository navigation
Conversation
Probe the leakless lock port before calling LockPort so EACCES/EPERM environments do not hang Browser.Get forever. EADDRINUSE still uses leakless retry for cross-process download serialization. Fixes go-rod#1232
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leakless.LockPortinBrowser.Get, probe binding127.0.0.1:<LockPort>.EACCESorEPERM, skip the TCP download lock soGetdoes not hang in restricted container networks.EADDRINUSE), behavior is unchanged: rod still delegates toleakless.LockPortand its retry loop for cross-process download serialization.This does not change leakless's
EADDRINUSEretry behavior; it only skips the lock when binding the lock port is not permitted.Fixes #1232
Test plan
go test ./lib/launcher -run 'TestDownloadPortLock|TestIsPermanentPortBindDenied'go test ./lib/launcher(note:TestManagedfails locally on main as well — context deadline / handshake assertion; unrelated to this change)