Repository navigation
Avoid caching helpers for reset contexts - #1240
Closed
yhuikzdtguioaert wants to merge 1 commit into
Closed
yhuikzdtguioaert wants to merge 1 commit into
yhuikzdtguioaert wants to merge 1 commit into
Conversation
A navigation can reset a JavaScript context while its helper is being created. In that case setHelper currently indexes a cache entry that has already been removed and panics. Only cache the helper when the context entry still exists, and cover full, per-context, and unchanged cache states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #707.
Testing
go test -count=20 -run TestPageSetHelperAfterContextReset .go vet ./...gofumpt -d page_eval.go page_eval_internal_test.gonpx -ys -- cspell@6.31.1 --no-progress page_eval.go page_eval_internal_test.goThe fork's Linux job stopped in
go generatebecause Chromium could not start with the hosted runner sandbox, and its macOS job stopped before tests with adyldLC_UUIDrunner/toolchain error.