feat: maintain ISO 4217 currency codes internally, drop govalidat… - #224
Open
nguyenvantuan2391996 wants to merge 1 commit into
Open
feat: maintain ISO 4217 currency codes internally, drop govalidat…#224nguyenvantuan2391996 wants to merge 1 commit into
nguyenvantuan2391996 wants to merge 1 commit into
Conversation
Benchmark ComparisonSummary:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 21 22 +1
Lines 954 957 +3
=======================================
+ Hits 948 951 +3
Misses 3 3
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarygovalidator.IsISO4217 hasn't been updated since v11.0.1 (2021) and is missing several currently active codes (VES, VED, MRU, SLE, XCG, ZWG), with no upstream release in sight to fix it Missing VES/VED from ISO4127 list #206.
Replace CurrencyCode's backing data with an internally maintained set of active ISO 4217 codes, sourced from the ISO 4217 Maintenance Agency (SIX Group) and cross-checked against datasets/currency-codes, snapshot 2026-08-14.
Add regression tests for the previously missing codes and for codes that have since been withdrawn (USS, ANG, BGN).