Repository navigation
test(genspec-tui): count every allocation when checking attribution - #110
Merged
Merged
Conversation
TestProfilerCapturesARun allocated a megabyte and asserted that the profiler attributed it. At the default rate the heap profiler samples one allocation per 512 KiB, so that megabyte is a Poisson draw with a mean of two, and the profile comes back empty about one run in seven — measured at 4 failures in 30 runs locally, independently of the toolchain. Pin MemProfileRate to 1 for the test, as the fabricated-record tests alongside it already do, so the assertion is about attribution rather than about luck. The runtime honours rate 1 from the very next allocation, with no threshold carried over from the previous rate. Nothing in the profiler changes: sampling is what the default rate means, and a phase whose sites were not sampled already says so on the card. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestProfilerCapturesARun allocated a megabyte and asserted that the profiler attributed it. At the default rate the heap profiler samples one allocation per 512 KiB, so that megabyte is a Poisson draw with a mean of two, and the profile comes back empty about one run in seven — measured at 4 failures in 30 runs locally, independently of the toolchain.
Pin MemProfileRate to 1 for the test, as the fabricated-record tests alongside it already do, so the assertion is about attribution rather than about luck. The runtime honours rate 1 from the very next allocation, with no threshold carried over from the previous rate.
Nothing in the profiler changes: sampling is what the default rate means, and a phase whose sites were not sampled already says so on the card.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist