fix(api): swap route registration order to prevent wildcard route hijacking list#167
Open
yuyudeqiu wants to merge 1 commit into
Open
fix(api): swap route registration order to prevent wildcard route hijacking list#167yuyudeqiu wants to merge 1 commit into
yuyudeqiu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
api/todo/v1/todo.proto, theGetTodoRPC (/v1/todos/{id}) was defined before theListTodosRPC (/v1/todos/list).Because Kratos registers routes in the order they are defined in the Proto file, the generated HTTP handlers in
todo_http.pb.goregistered the wildcard route/v1/todos/{id}first. Consequently, requests toGET /v1/todos/listwere intercepted by theGetTodohandler withid="list", causing a decoding failure (400 Bad Request):{"code":400, "reason":"CODEC", "message":"parsing field \"id\": strconv.ParseInt: parsing \"list\": invalid syntax"}Changes
ListTodosandGetTodoorder inapi/todo/v1/todo.prototo ensure/v1/todos/listis registered first.Verification & Testing
Tested locally with the HTTP server:
POST /v1/todos/createsucceeds.GET /v1/todos/listcorrectly hits the list endpoint and returns the collection list.GET /v1/todos/{id}correctly fetches single items and returns 404 for non-existent IDs.