fix: replace hardcoded DB password in project template config#166
Open
saaa99999999 wants to merge 1 commit into
Open
fix: replace hardcoded DB password in project template config#166saaa99999999 wants to merge 1 commit into
saaa99999999 wants to merge 1 commit into
Conversation
- configs/config.yaml: replaced hardcoded "root:root" MySQL credentials with
${DB_DSN} placeholder
This is the official Kratos project template used by every new Kratos project.
The default config contains a hardcoded database password that new projects
inherit unless explicitly changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The project template config ships with a hardcoded MySQL root password. Every project created with
kratos newinherits these credentials.What was there
configs/config.yaml — the template checked into the repo:
root:rootis embedded in the DSN string. New projects start with these credentials unless the developer explicitly overwrites them.What changed
Replaced with an env var placeholder:
The host/port/db defaults are preserved but the password is no longer hardcoded in the template.
See also: CWE-798