fix: Git_Bash calculation error in windows powershell.#139
Conversation
|
I am considering using buf directly to |
|
@shenqidebaozi I think that is a breaking change in next major version. This issue is a bug fix in next patch version. There is no conflict between them. |
windzhu0514
left a comment
There was a problem hiding this comment.
not working on windows when use Git Bash.the problem is to find a way to compatible with git-bash,cmd and linux bash.
@windzhu0514 It is no need to calculate 原文: |
The file sturcture of git it's looks like below in windows:
Makefile used the code below to calculate the path of "bash.exe".
But it used a wrong command
dir.diris a command likels ., even in windows. So user that using windows can not get a correct "Git_Bash". And now I have fixed this issue.Makefile 计算 bash.exe 路径的时候使用了一个叫
dir的命令。这里的原意是想获取一个路径的目录名,例如 "/a/b/c.exe" -> "/a/b"。但dir实际上相当于ls .,就算在 windows 中也是这样。也就是说用错命令了。不过 windows 里也没有
dirname命令,所以我用了其他的手段解决问题。