ci: remove legacy manual-release.yml workflow#161
Merged
Conversation
The manual release workflow is a legacy, self-contained publish path that duplicated the release pipeline with an older approach: it authenticated with a stored NPM_TOKEN instead of the OIDC trusted publishing used by release.yml, relied on deprecated actions (actions/create-release@v1, actions/upload-release-asset@v1), and its asset-upload step referenced a non-existent step id (steps.create_release) so it could not have worked. Its release notes were also hardcoded and stale. Releases are handled by the create-tag-and-draft-release job (nodejs.yml) plus release.yml. Drop the manual workflow and its doc references. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F3RYg3wG5UhVTCx58596iW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
.github/workflows/manual-release.yml, a legacy manual-publish path that duplicated the release pipeline with an outdated and partly-broken approach.Why
Releases are handled by the two-step automated flow:
create-tag-and-draft-release(innodejs.yml) creates the tag + draft GitHub Release on a version-bump push to master.release.ymlpublishes to npm via OIDC trusted publishing when that release is published.manual-release.ymlwas a separate, self-contained parallel path that had drifted out of line with this flow:NPM_TOKENinstead of the OIDC trusted publishingrelease.ymldeliberately moved to.actions/create-release@v1andactions/upload-release-asset@v1.steps.create_release.outputs.upload_url, but the release step is id'drelease_notes, soupload_urlis always empty; that step could not have worked.Changes
.github/workflows/manual-release.yml.README.mdanddocs/maintenance.md.The
create-tag-and-draft-releasejob andrelease.ymlare left intact — they're the active release pipeline.Note
This removes the only workflow that offered a manual
prerelease/--tag betapublish. If that capability is still wanted, it should be re-added on top of the OIDC flow rather than kept in the old token-based form.🤖 Generated with Claude Code
https://claude.ai/code/session_01F3RYg3wG5UhVTCx58596iW
Generated by Claude Code