Skip to content

fix: exclude Android build output from package - #32

Merged
piotr-graczyk-dev merged 1 commit into
mainfrom
codex/release-package-files
Jun 29, 2026
Merged

fix: exclude Android build output from package#32
piotr-graczyk-dev merged 1 commit into
mainfrom
codex/release-package-files

Conversation

@piotr-graczyk-dev

Copy link
Copy Markdown
Contributor

Summary

  • constrain package Android files to source/config paths
  • avoid including local Gradle build output in the npm tarball

Validation

  • bun run build
  • bun run test:ci
  • npm pack --dry-run --ignore-scripts --json with temporary npm cache

@piotr-graczyk-dev
piotr-graczyk-dev requested a review from a team June 29, 2026 14:11
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e9c4838f-b769-4523-a5ff-0d2798ca783e

📥 Commits

Reviewing files that changed from the base of the PR and between fae9b9b and 8030ccf.

📒 Files selected for processing (1)
  • package/package.json

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Expanded the Android files included in the published package, so more Android project assets are available in releases.

Walkthrough

The files publish whitelist in package/package.json replaces the single "android" directory entry with four explicit subpaths: android/CMakeLists.txt, android/README.md, android/build.gradle, and android/src.

Changes

Android Publish Whitelist

Layer / File(s) Summary
Android files whitelist
package/package.json
Replaces the broad "android" directory entry with four explicit subpaths: CMakeLists.txt, README.md, build.gradle, and src.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the package whitelist change to keep Android build output out of the tarball.
Description check ✅ Passed The description is directly related to the Android package contents and tarball exclusion changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Check ✅ Passed No high-confidence vulnerability: the change only narrows published Android files and removes build output from the npm tarball.

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

React Doctor found 7 issues in 7 files · 7 warnings · score 86 / 100 (Great) · full project

7 warnings

App.tsx

  • ⚠️ L2 React 19 API migration can break callers no-react19-deprecated-apis

examples/advancedFeatures.ts

  • ⚠️ L115 unused-export

src/components/MapView.tsx

  • ⚠️ L1 React 19 API migration can break callers no-react19-deprecated-apis

src/hooks/index.ts

  • ⚠️ L0 unused-file

src/hooks/useCollectedOverlays.ts

  • ⚠️ L204 Ref initializer runs on every render rerender-lazy-ref-init

src/providers.ts

  • ⚠️ L11 unused-export

src/utils/enteringAnimation.ts

  • ⚠️ L33 unused-export

Reviewed by React Doctor for commit 8030ccf. See inline comments for fixes.

@piotr-graczyk-dev
piotr-graczyk-dev merged commit ec54e12 into main Jun 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants