fix: adapt encode_blocks to alloy 0.12 get_block_by_number API - #139
Open
creditcoinprotoclaw wants to merge 1 commit into
Open
fix: adapt encode_blocks to alloy 0.12 get_block_by_number API#139creditcoinprotoclaw wants to merge 1 commit into
creditcoinprotoclaw wants to merge 1 commit into
Conversation
alloy 0.12 changed get_block_by_number to take only BlockNumberOrTag and return an EthGetBlock builder; use .full() for full transactions and drop the now-unused BlockTransactionsKind import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #16 (the alloy 0.11 → 0.12.6 bump).
PR #16 bumps alloy but leaves the source using the old API, so
cargo-checkfails with:alloy-rpc-types-ethversions in tree before the bump)get_block_by_numbertakes 1 arg, not 2alloy 0.12 changed
get_block_by_numberto take onlyBlockNumberOrTagand return anEthGetBlockbuilder. This commit:BlockTransactionsKind::Fullarg.get_block_by_number(n.into()).full().awaitBlockTransactionsKindimportMerge #16 first (or merge this into #16 branch), then #16 should pass CI.
cargo fmtclean. Couldn't runcargo checklocally (no linker in sandbox); relying on PR CI.