DEBUG: retest alloy vs ethers encoding on fixed block 25463089 - #122
Closed
creditcoinprotoclaw wants to merge 1 commit into
Closed
DEBUG: retest alloy vs ethers encoding on fixed block 25463089#122creditcoinprotoclaw wants to merge 1 commit into
creditcoinprotoclaw wants to merge 1 commit into
Conversation
Both encoders subscribed to live blocks over a timeout window, so the two CI jobs could encode non-overlapping block sets, making the comparison flaky. Add an optional single-block mode to each encoder: - rust: new --target-block <n> arg; encode that block once then exit - ts: optional 3rd positional [targetBlockNumber]; same behavior The compare-encoding-ethereum workflow now pins both jobs to block 25463089 (RETEST_BLOCK) so alloy vs ethers encoding is compared deterministically on the exact same block. DEBUG: for retesting only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DEBUG/retest PR so we can compare alloy vs ethers encoding on the same block
25463089, deterministically.Follow-up to the failed scheduled run:
https://github.com/gluwa/cc-next-query-builder/actions/runs/28725162421/job/85184687006
Why
Today both
alloy-encode(Rust) andethers-encode(TS) subscribe to live blocks and encode whatever arrives during a timeout window. The two jobs therefore often encode non-overlapping block sets, socompare-data's--diff-filter=Monly compares whatever blocks happen to overlap — making the comparison flaky and hard to reproduce for a specific block.Changes
--target-block <n>arg. When set, encode exactly that block once, then exit (instead of live-subscribing).[targetBlockNumber]. Same behavior; mirrors the Rust side.RETEST_BLOCK: '25463089'; both encode steps now pass it to their encoder so both jobs encode the identical block.compare-datadiff logic unchanged.Verification
cargo fmt --check✅,cargo build --release✅ (pre-existing clippy lints onmainleft untouched — CI does not gate on clippy)prettier --check✅,tscbuild ✅To retest: trigger this workflow (workflow_dispatch) on this branch and check the
compare-datajob diff for block25463089.Draft: intended for retest/DEBUG purposes.