Skip to content
This repository was archived by the owner on Jul 7, 2020. It is now read-only.

@kubectl@ --show-all option is defaulted to true and deprecated since 1.11 and removed since 1.14 - #576

Open
fbarco wants to merge 6 commits into
gluster:masterfrom
fbarco:gk-deploy-kubectl-option
Open

@kubectl@ --show-all option is defaulted to true and deprecated since 1.11 and removed since 1.14#576
fbarco wants to merge 6 commits into
gluster:masterfrom
fbarco:gk-deploy-kubectl-option

Conversation

@fbarco

@fbarco fbarco commented Apr 5, 2019

Copy link
Copy Markdown
  • deploy/gk-deploy : remove @--show-all@ option to @kubectl@ command line

~$ kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-25T15:53:57Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-25T15:45:25Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}

~$ kubectl get pods --show-all --no-headers -l job-name=heketi-storage-copy-job
Error: unknown flag: --show-all
....
Use "kubectl options" for a list of global command-line options (applies to all commands).

unknown flag: --show-all


This change is Reviewable

… 1.11 and removed since 1.14

* deploy/gk-deploy : remove @--show-all@ option to @kubectl@ command line
@centos-ci

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@nixpanic

nixpanic commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

This might be needed in previous versions? It would probably be good to add the --show-all option for versions < 1.13.

@jarrpa what do you think?

@fbarco

fbarco commented Apr 8, 2019

Copy link
Copy Markdown
Author

Since version 1.11, --show-all option is deprecated and defaulted to true, so it can be removed from the command line.
Does the versions < 1.11 are still supported ?
If yes, i can propose a patch which set this option when version is < 1.11.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants